Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(values): add values in src/object #687

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ankitjha420
Copy link
Contributor

This PR adds the function values. It was mentioned on the issue #669 and on the Compatibility documentation
Please let me know if there are any mistakes in my code, thanks <3

@ankitjha420 ankitjha420 requested a review from raon0211 as a code owner October 7, 2024 16:32
Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 4:37pm

@raon0211
Copy link
Collaborator

raon0211 commented Oct 22, 2024

Hello :) Thanks for your contribution! Meanwhile, I think we have a good native API called Object.values(...), why not add this into our compatibility library es-toolkit/compat?

You can refer to functions like ceil to check how we handle these kinds of functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants